Re: Allow declaration after statement and reformat code to use it

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Allow declaration after statement and reformat code to use it
Дата
Msg-id YR7udcZOjOiFQs55@paquier.xyz
обсуждение исходный текст
Ответ на Re: Allow declaration after statement and reformat code to use it  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Thu, Aug 19, 2021 at 10:34:04AM -0400, Tom Lane wrote:
> Ranier Vilela <ranier.vf@gmail.com> writes:
>> C needs readability, not fewer lines.
>> Aside from horrible code, it doesn't improve 0.1% on anything.
>> I think it's a bad idea and I'm strongly against it.
>
> Same here.  We have thirty-ish years worth of coding habits developed
> around the existing C90-based layout rules.  I really doubt that a
> quasi-mechanical transformation is going to result in better code style.
> What it certainly will do, though, is create a pile of hazards for
> back-patching.

The back-patching hazard this could create is an argument enough to
avoid any of that IMO if done only on HEAD.  When a bug is involved,
up to 7 branches may require a fix.  That's already a lot of work.
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: elog.c query_id support vs shutdown
Следующее
От: Jacob Champion
Дата:
Сообщение: Re: badly calculated width of emoji in psql