Re: Error on pgbench logs

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Error on pgbench logs
Дата
Msg-id YMMBbVVIQgs9B5oK@paquier.xyz
обсуждение исходный текст
Ответ на Re: Error on pgbench logs  (Fabien COELHO <coelho@cri.ensmp.fr>)
Ответы Re: Error on pgbench logs  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Re: Error on pgbench logs  (Fabien COELHO <coelho@cri.ensmp.fr>)
Список pgsql-hackers
On Thu, Jun 10, 2021 at 11:29:30PM +0200, Fabien COELHO wrote:
> +        /* flush remaining stats */
> +        if (!logged && latency == 0.0)
> +            logAgg(logfile, agg);

You are right, this is missing the final stats.  Why the choice of
latency here for the check?  That's just to make the difference
between the case where doLog() is called while processing the
benchmark for the end of the transaction and the case where doLog() is
called once a thread ends, no?  Wouldn't it be better to do a final
push of the states once a thread reaches CSTATE_FINISHED or
CSTATE_ABORTED instead?
--
Michael

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jeff Davis
Дата:
Сообщение: Re: Question about StartLogicalReplication() error path
Следующее
От: Amit Langote
Дата:
Сообщение: Re: Multi-Column List Partitioning