RE: batch fdw insert bug (Postgres 14)

Поиск
Список
Период
Сортировка
От tsunakawa.takay@fujitsu.com
Тема RE: batch fdw insert bug (Postgres 14)
Дата
Msg-id OSAPR01MB29770C911D80E979CFC2B7EBFE549@OSAPR01MB2977.jpnprd01.prod.outlook.com
обсуждение исходный текст
Ответ на Re: batch fdw insert bug (Postgres 14)  (Tomas Vondra <tomas.vondra@enterprisedb.com>)
Список pgsql-hackers
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
> I think the simplest fix is simply to pstrdup() the query when building
> fmstate in create_foreign_modify. We've already been doing that for
> orig_query anyway. That seems cleaner than printing the last query we
> build (which would be confusing I think).
> 
> I've pushed a fix doing that. We only need that for INSERT queries, and
> we might even restrict that to cases with batching if needed.

Thank you for investigating and committing the fix.  (I'm relieved that the feature was not reverted.)


Regards
Takayuki Tsunakawa


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: JSON doc example (matchiness)
Следующее
От: "tsunakawa.takay@fujitsu.com"
Дата:
Сообщение: RE: Inaccurate error message when set fdw batch_size to 0