On Tue, Mar 8, 2022 at 4:48 PM Kuroda, Hayato/黒田 隼人 <kuroda.hayato@fujitsu.com> wrote:
> Thank you for updating the patch! Good self-reviewing.
Thanks for your comments.
> > And I looked into the function WalSndUpdateProgress. I found function
> > WalSndUpdateProgress try to record the time of some message(by
> > function
> > LagTrackerWrite) sent to subscriber, such as in function pgoutput_commit_txn.
>
> Yeah, I think you are right.
>
> > Then, when publisher receives the reply message from the
> > subscriber(function ProcessStandbyReplyMessage), publisher invokes
> > LagTrackerRead to calculate the delay time(refer to view
> > pg_stat_replication).
> > Referring to the purpose of LagTrackerWrite, I think it is no need to
> > log time when sending keepalive messages here.
> > So when the parameter send_keep_alive of function WalSndUpdateProgress
> > is true, skip the recording time.
>
> I also read them. LagTracker records the elapsed time between sending commit
> from publisher and receiving reply from subscriber, right? It seems good.
Yes.
> Do we need adding a test for them? I think it can be added to 100_bugs.pl.
> Actually I tried to send PoC, but it does not finish to implement that.
> I'll send if it is done.
I'm not sure if it is worth it.
Because the reproduced test of this bug might take some time and might risk
making the build farm slow, so I am not sure if others would like the
reproduced test of this bug.
Regards,
Wang wei