RE: Remove "FROM" in "DELETE FROM" when using tab-completion

Поиск
Список
Период
Сортировка
От tanghy.fnst@fujitsu.com
Тема RE: Remove "FROM" in "DELETE FROM" when using tab-completion
Дата
Msg-id OS0PR01MB61134FBD0190BC0D7117644FFB539@OS0PR01MB6113.jpnprd01.prod.outlook.com
обсуждение исходный текст
Ответ на Re: Remove "FROM" in "DELETE FROM" when using tab-completion  (Dilip Kumar <dilipbalaut@gmail.com>)
Ответы Re: Remove "FROM" in "DELETE FROM" when using tab-completion
Список pgsql-hackers
On Tuesday, May 11, 2021 5:44 PM, Dilip Kumar <dilipbalaut@gmail.com> wrote:
>But your patch is doing nothing to add the implementation for DELETE..
>USING.  Basically, the tab completion support for DELETE....USING is
>still pending right?

I see, maybe I have a misunderstanding here, I thought tab completion for "DELETE....USING" means the code before it as
follows.
> >    else if (TailMatches("DELETE", "FROM", MatchAny))
> >            COMPLETE_WITH("USING", "WHERE");

So I just thought the tab completion support for DELETE....USING is not pending anymore.
According to your feedback, maybe something beyond my knowledge is need to be done for DELETE....USING.

Besides, you are right, the fix in the patch has nothing to do with the comment here.
Patch updated to V2 with the sentence moved back. Thanks.

Regards,
Tang

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrey Lepikhov
Дата:
Сообщение: Re: Asynchronous Append on postgres_fdw nodes.
Следующее
От: Julien Rouhaud
Дата:
Сообщение: Re: compute_query_id and pg_stat_statements