pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows.

Поиск
Список
Период
Сортировка
От Noah Misch
Тема pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows.
Дата
Msg-id E1qrnXz-000aIJ-HU@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Don't spuriously report FD_SETSIZE exhaustion on Windows.

Starting on 2023-08-03, this intermittently terminated a "pgbench -C"
test in CI.  It could affect a high-client-count "pgbench" without "-C".
While parallel reindexdb and vacuumdb reach the same problematic check,
sufficient client count and/or connection turnover is less plausible for
them.  Given the lack of examples from the buildfarm or from manual
builds, reproducing this must entail rare operating system
configurations.  Also correct the associated error message, which was
wrong for non-Windows.  Back-patch to v12, where the pgbench check first
appeared.  While v11 vacuumdb has the problematic check, reaching it
with typical vacuumdb usage is implausible.

Reviewed by Thomas Munro.

Discussion: https://postgr.es/m/CA+hUKG+JwvTNdcyJTriy9BbtzF1veSRQ=9M_ZKFn9_LqE7Kp7Q@mail.gmail.com

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/06ff064842832187fce7474e866010d2764a066a

Modified Files
--------------
src/bin/pgbench/pgbench.c    | 19 ++++++++++++++-----
src/fe_utils/parallel_slot.c | 37 +++++++++++++++++++++++++++++++++++--
2 files changed, 49 insertions(+), 7 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Harden xxx_is_visible() functions against concurrent object drop
Следующее
От: Noah Misch
Дата:
Сообщение: pgsql: Don't spuriously report FD_SETSIZE exhaustion on Windows.