pgsql: Fix assert in BRIN build_distances

Поиск
Список
Период
Сортировка
От Tomas Vondra
Тема pgsql: Fix assert in BRIN build_distances
Дата
Msg-id E1pBLOO-001CEv-8K@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix assert in BRIN build_distances

When brin_minmax_multi_union merges summaries, we may end up with just a
single range after merge_overlapping_ranges. The summaries may contain
just one range each, and they may overlap (or be exactly the same).

With a single range there's no distance to calculate, but we happen to
call build_distances anyway - which is fine, we don't calculate the
distance in this case, except that with asserts this failed due to a
check there are at least two ranges.

The assert is unnecessarily strict, so relax it a bit and bail out if
there's just a single range. The relaxed assert would be enough, but
this way we don't allocate unnecessary memory for distance.

Backpatch to 14, where minmax-multi opclasses were introduced.

Reported-by: Jaime Casanova
Backpatch-through: 14
Discussion: https://postgr.es/m/YzVA55qS0hgz8P3r@ahch-to

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/02699bc1fd3b7fccba2e6b55189a148ef69b8a00

Modified Files
--------------
src/backend/access/brin/brin_minmax_multi.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tomas Vondra
Дата:
Сообщение: pgsql: Fix assert in BRIN build_distances
Следующее
От: Tomas Vondra
Дата:
Сообщение: pgsql: Sample postgres_fdw tables remotely during ANALYZE