Fix incorrect output from pgoutput when using column lists.
For Updates and Deletes, we were not honoring the columns list for old
tuple values while sending tuple data via pgoutput. This results in
pgoutput emitting more columns than expected.
This is not a problem for built-in logical replication as we simply ignore
additional columns based on the relation information sent previously which
didn't have those columns. However, some other users of pgoutput plugin
may expect the columns as per the column list. Also, sending extra columns
unnecessarily consumes network bandwidth defeating the purpose of the
column list feature.
Reported-by: Gunnar Morling
Author: Hou Zhijie
Reviewed-by: Amit Kapila
Backpatch-through: 15
Discussion: https://postgr.es/m/CADGJaX9kiRZ-OH0EpWF5Fkyh1ZZYofoNRCrhapBfdk02tj5EKg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/40b1491357a4a092ea054176944cf76e2fe3eff8
Modified Files
--------------
src/backend/replication/logical/proto.c | 7 +++---
src/backend/replication/pgoutput/pgoutput.c | 6 ++++--
src/include/replication/logicalproto.h | 2 +-
src/test/subscription/t/031_column_list.pl | 33 +++++++++++++++++++++++++++++
4 files changed, 42 insertions(+), 6 deletions(-)