pgsql: Fix TestLib::slurp_file() with offset on windows.

Поиск
Список
Период
Сортировка
От Andres Freund
Тема pgsql: Fix TestLib::slurp_file() with offset on windows.
Дата
Msg-id E1mXUth-0007NU-SV@gemulon.postgresql.org
обсуждение исходный текст
Список pgsql-committers
Fix TestLib::slurp_file() with offset on windows.

3c5b0685b921 used setFilePointer() to set the position of the filehandle, but
passed the wrong filehandle, always leaving the position at 0. Instead of just
fixing that, remove use of setFilePointer(), we have a perl fd at this point,
so we can just use perl's seek().

Additionally, the perl filehandle wasn't closed, just the windows filehandle.

Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de
Backpatch: 9.6-, like 3c5b0685b921

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/cd1b2334b8a2c18f54e7ade408c9133805cae557

Modified Files
--------------
src/test/perl/TestLib.pm | 36 ++++++++++++++++++------------------
1 file changed, 18 insertions(+), 18 deletions(-)


В списке pgsql-committers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: pgsql: Fix TestLib::slurp_file() with offset on windows.
Следующее
От: Andres Freund
Дата:
Сообщение: pgsql: Fix TestLib::slurp_file() with offset on windows.