pgsql: Don't use custom OID symbols in pg_proc.dat.

Don't use custom OID symbols in pg_proc.dat.

We have a perfectly good convention for OID macros for built-in functions
already, so making custom symbols is just introducing unnecessary
deviation from the convention.  Remove the one case that had snuck in,
and add an error check in genbki.pl to discourage future instances.

Although this touches pg_proc.dat, there's no need for a catversion
bump since the actual catalog data isn't changed.

John Naylor

Discussion: https://postgr.es/m/CAFBsxsHpCbjfoddNGpnnnY5pHwckWfiYkMYSF74PmP1su0+ZOw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/36b93121436cbbf357974144068c23bac75154fa

Modified Files
--------------
src/backend/catalog/genbki.pl      | 7 +++++++
src/backend/utils/cache/relcache.c | 4 ++--
src/include/catalog/pg_proc.dat    | 3 +--
3 files changed, 10 insertions(+), 4 deletions(-)