pgsql: Fix memory leak in LogStandbySnapshot().

Fix memory leak in LogStandbySnapshot().

The array allocated by GetRunningTransactionLocks() needs to be pfree'd
when we're done with it.  Otherwise we leak some memory during each
checkpoint, if wal_level = hot_standby.  This manifests as memory bloat
in the checkpointer process, or in bgwriter in versions before we made
the checkpointer separate.

Reported and fixed by Naoya Anzai.  Back-patch to 9.0 where the issue
was introduced.

In passing, improve comments for GetRunningTransactionLocks(), and add
an Assert that we didn't overrun the palloc'd array.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/81fe138ba252987815506caa57719822709b730f

Modified Files
--------------
src/backend/storage/ipc/standby.c |    7 +------
src/backend/storage/lmgr/lock.c   |   16 +++++++++++++---
2 files changed, 14 insertions(+), 9 deletions(-)