1) Test and results are in attachments. Everything seems to work as expected. 2) I dropped these notices. It was done only for debug purposes. Updated patch is attached. 3) fixed
Good! Another couple of notes from me:
1) I think gistvacuumpage() and gistkillitems() need function-level comments.
2) ItemIdIsDead() can be used in index scan like it's done in _bt_checkkeys().
------ Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company