[HACKERS] Fix bloom WAL tap test

Поиск
Список
Период
Сортировка
От Alexander Korotkov
Тема [HACKERS] Fix bloom WAL tap test
Дата
Msg-id CAPpHfdtohPdQ9rc5mdWjxq+3VsBNw534KV_5O65dTQrSdVJNgw@mail.gmail.com
обсуждение исходный текст
Ответы Re: [HACKERS] Fix bloom WAL tap test  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
Список pgsql-hackers
Дерево обсуждения
Hi!

I just realized that these lines of contrib/bloom/t/001_wal.pl don't check that queries give same results on master and standby.  They just check that *return codes* of psql are equal.

# Run test queries and compare their result
my $master_result = $node_master->psql("postgres", $queries);
my $standby_result = $node_standby->psql("postgres", $queries);
is($master_result, $standby_result, "$test_name: query result matches");

Attached patch fixes this problem by using safe_psql() which returns psql output instead of return code.  For safety, this patch replaces psql() with safe_psql() in other places too.

I think this should be backpatched to 9.6 as bugfix.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: [HACKERS] Rewriting the test of pg_upgrade as a TAP test
Следующее
От: Simon Riggs
Дата:
Сообщение: Re: [HACKERS] [COMMITTERS] pgsql: Add psql variables showing serverversion and psql version.