Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.

Поиск
Список
Период
Сортировка
От Etsuro Fujita
Тема Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.
Дата
Msg-id CAPmGK16_SxSMX=2MLCkv62tN29XbC4rrcQKWYLtp13smweT9Jw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage.  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Ответы Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdwmessage.  (Gilles Darold <gilles@darold.net>)
Список pgsql-hackers
Horiguchi-san,

On Thu, Nov 7, 2019 at 5:31 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
> I forgot to mention that the comment in XACT_EVENT_PRE_PREPARE
> contains the same mistake and needs more or less the same fix.

Good catch!  How about rewriting "We disallow remote transactions that
modified anything" in the comment simply to "We disallow any remote
transactions" or something like that?  Attached is an updated patch.
In the patch, I did s/prepare/PREPARE/ to the error message as well,
as you proposed.

Thanks again for reviewing!

Best regards,
Etsuro Fujita

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Rafia Sabih
Дата:
Сообщение: Re: Parallel leader process info in EXPLAIN
Следующее
От: Tomas Vondra
Дата:
Сообщение: Re: Using multiple extended statistics for estimates