Re: Re-[Sonarqube]- Clumsy code

Поиск
Список
Период
Сортировка
От Akshay Joshi
Тема Re: Re-[Sonarqube]- Clumsy code
Дата
Msg-id CANxoLDc0CJYrg9qcMBo791m-1eR33k8OtPWXzXB+zhkd4wZHNg@mail.gmail.com
обсуждение исходный текст
Ответ на Re-[Sonarqube]- Clumsy code  (Satish V <satish.v@enterprisedb.com>)
Ответы Re: Re-[Sonarqube]- Clumsy code
Список pgadmin-hackers
Дерево обсуждения
Hi Satish

Fixes like below will create another code smell in SonarQube:
  • !(m.label == 'pg_global') should be (m.label != 'pg_global')
  • !(_.isUndefined(index) || index == '');
  • !(_.has(itemData, 'label') && itemData.label === '_RETURN');
  • .....
Please fix such errors correctly and resend the patch. Make sure functionality should work properly.

On Thu, Jun 18, 2020 at 11:27 AM Satish V <satish.v@enterprisedb.com> wrote:
Hi Hackers,

Please find the patch in the attachment which resolves below issue.
1.Replace this if-then-else statement by a single return statement.

Kindy review and share the changes, if required

Thanks,
Sathish V


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Yogesh Mahajan
Дата:
Сообщение: [pgAdmin4][Patch] - Issue fixes reported by SonarQube - 4 (Rule Comma operator should not be used)
Следующее
От: Aditya Toshniwal
Дата:
Сообщение: Re: [pgAdmin][patch] Sonarqube issues tagged as redundant