Re: [PATCH] LockAcquireExtended improvement

Поиск
Список
Период
Сортировка
От Will Mortensen
Тема Re: [PATCH] LockAcquireExtended improvement
Дата
Msg-id CAMpnoC7uymaewKschMUy5703xfi31ivjZiFKyurjQ=MWqLnP-Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] LockAcquireExtended improvement  (Will Mortensen <will@extrahop.com>)
Ответы Re: [PATCH] LockAcquireExtended improvement
Список pgsql-hackers
On Tue, Mar 26, 2024 at 7:14 PM Will Mortensen <will@extrahop.com> wrote:
> This comment on ProcSleep() seems to have the values of dontWait
> backward (double negatives are tricky):
>
>     * Result: PROC_WAIT_STATUS_OK if we acquired the lock,
> PROC_WAIT_STATUS_ERROR
>     * if not (if dontWait = true, this is a deadlock; if dontWait = false, we
>     * would have had to wait).
>
> Also there's a minor typo in a comment in LockAcquireExtended():
>
>     * Check the proclock entry status. If dontWait = true, this is an
>     * expected case; otherwise, it will open happen if something in the
>     * ipc communication doesn't work correctly.
>
> "open" should be "only".

Here's a patch fixing those typos.

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Thomas Munro
Дата:
Сообщение: Re: race condition when writing pg_control
Следующее
От: "Andrey M. Borodin"
Дата:
Сообщение: Re: allow sorted builds for btree_gist