On Thu, Aug 10, 2023 at 8:57 AM Julien Rouhaud <rjuju123@gmail.com> wrote:
On Wed, Aug 09, 2023 at 10:29:56AM -0500, Tristan Partin wrote: > On Wed Aug 9, 2023 at 10:02 AM CDT, Peter Eisentraut wrote: > > > > This patch has apparently upset one buildfarm member with a very old > > compiler: > > https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=lapwing&br=HEAD > > > > Any thoughts? > > Best I could find is SO question[0] which links out to[1]. Try this patch. > Otherwise, a memset() would probably do too.
Yes, it's a buggy warning that came up in the past a few times as I recall, for which we previously used the {{...}} approach to silence it.
I came across this warning too on one of my VMs, with gcc 4.8.5. +1 to silence it with {{...}}. We did that in d937904 and 6392f2a (and maybe more).
In case it helps, here is the GCC I'm on.
$ gcc --version gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)