Re: GetSubscriptionRelations declares too many scan keys

Поиск
Список
Период
Сортировка
От Bharath Rupireddy
Тема Re: GetSubscriptionRelations declares too many scan keys
Дата
Msg-id CALj2ACX5ocSjjUP6Su36g1_G7L7ghqXPKO5XjdY2HhjNkZ0VVw@mail.gmail.com
обсуждение исходный текст
Ответ на GetSubscriptionRelations declares too many scan keys  (Peter Smith <smithpb2250@gmail.com>)
Ответы Re: GetSubscriptionRelations declares too many scan keys  (Julien Rouhaud <rjuju123@gmail.com>)
Re: GetSubscriptionRelations declares too many scan keys  (Peter Smith <smithpb2250@gmail.com>)
Список pgsql-hackers
On Mon, May 10, 2021 at 12:36 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> The function GetSubscriptionRelations was declaring ScanKeyData
> skey[2]; but actually
> only uses 1 scan key. It seems like the code was cut/paste from other
> nearby functions
> which really are using 2 keys.
>
> PSA a trivial patch to declare the correct number of keys for this function.

+1 for the change. It looks like a cut/paste type introduced by the
commit 7c4f52409a.

A comment on the patch: why do we need to declare an array of 1
element ScanKeyData skey[1];? Instead, can we just do ScanKeyData
skey;?

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Thomas Munro
Дата:
Сообщение: Re: seawasp failing, maybe in glibc allocator
Следующее
От: Peter Smith
Дата:
Сообщение: Re: row filtering for logical replication