Hi,
While I was reviewing one of the logical decoding features, I found a
few issues in alter subscription drop publication.
Alter subscription drop publication does not support copy_data option,
that needs to be removed from tab completion.
Dropping all the publications present in the subscription using alter
subscription drop publication would throw "subscription must contain
at least one publication". This message was slightly confusing to me.
As even though some publication was present on the subscription I was
not able to drop. Instead I feel we could throw an error message
something like "dropping specified publication will result in
subscription without any publication, this is not supported".
merge_publications can be called after validation of the options
specified, I think we should check if the options specified are
correct or not before checking the actual publications.
Attached a patch which contains the fixes for the same.
Thoughts?
Regards,
Vignesh