On Fri, Jan 15, 2016 at 3:34 PM, David Rowley <david.rowley@2ndquadrant.com> wrote: > On 8 January 2016 at 22:43, David Rowley <david.rowley@2ndquadrant.com> > wrote: >> >> I've attached some re-based patched on current master. This is just to fix >> a duplicate OID problem. >> > > I've attached two updated patched to fix a conflict with a recent change to > planner.c
I am getting following compilation error and warning with the latest patch, because of a function prototype mismatch.
aggregatecmds.c: In function ‘DefineAggregate’: aggregatecmds.c:93:8: warning: variable ‘serialTypeType’ set but not used [-Wunused-but-set-variable] char serialTypeType = 0; ^ clauses.c:434:1: error: conflicting types for ‘partial_aggregate_walker’ partial_aggregate_walker(Node *node, partial_agg_context *context) ^ clauses.c:100:13: note: previous declaration of ‘partial_aggregate_walker’ was here static bool partial_aggregate_walker(Node *node, void *context); ^
Thanks for noticing that. The compiler I used didn't seem to mind that... Which is a bit of a worry.
I've attached an updated patch, and the same test patch again.