On 7 July 2018 at 01:08, Alexander Kuzmenkov <a.kuzmenkov@postgrespro.ru> wrote:
> Great. I think we can use the same approach for make_inh_translation_list,
> as in the attached patch. It show some improvement on test 6. I got the
> following tps, median of 11 runs (forgot to turn off fsync though):
>
> test master v3 v4
> 1 414 416 408
> 2 259 409 404
> 3 263 400 405
> 4 417 416 404
> 5 118 311 305
> 6 85 280 303
Nice. I think that's a good idea. Although, I didn't really like the
use of the comma operator you added. I think since TupleDescAttr can't
be NULL we can just do:
(att = TupleDescAttr(new_tupdesc, new_attno))->attisdropped
There's no shortage of other places that do TupleDescAttr(...)-> so I
think that's perfectly fine.
I also did a slight rewording of the comment above that new code. I've
attached v5.
Please feel free to add yourself as an author of this patch in the
commitfest app. You've probably contributed about as much as I have to
this.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services