Re: Add version and data directory to initdb output

Поиск
Список
Период
Сортировка
От David G. Johnston
Тема Re: Add version and data directory to initdb output
Дата
Msg-id CAKFQuwYTtKeLnsHgo71BWeXHk_m+PZFdpVzEECr=RfZYLJa04A@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Add version and data directory to initdb output  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Thu, Apr 21, 2022 at 7:18 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> I'm not a particular fan of the current initdb output and it could use a
> general revision IMO.  If you want to look into that, please do.  But
> for your particular proposed addition, let's put it somewhere it makes
> sense either in the current scheme or a future scheme when that is done.

TBH, I think we should reject the current proposal outright.
The target directory's name already appears twice in initdb's output;
we do not need a third time.  And as for the version, if you want that
you can get it from "initdb --version".


I don't really see a reason not to add the version to the log output, if just for simplicity and having a self-contained stream of content.

I'm off my desire to have it be the nearly last thing to print though; having it print first actually works better since if you are interactive you'll see it pop-up just after pressing enter.  Subconsciously you'll know what you are expecting to see there and if it just happens to be different you'll probably notice it.  Solutions requiring additional commands/effort to retrieve the version presume one is expecting/caring about checking that value specifically, and while that may be true the simplicity combined with the benefit to people not expecting there to be an issue make adding it alongside the various others key=value settings a no-brainer for me.

David J.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Banck
Дата:
Сообщение: Re: Add version and data directory to initdb output
Следующее
От: Adam Lippai
Дата:
Сообщение: COPY TO STDOUT Apache Arrow support