Re: Removal of duplicate variable declarations in fe-connect.c

Поиск
Список
Период
Сортировка
Искать
От
Haribabu Kommi
Тема
Re: Removal of duplicate variable declarations in fe-connect.c
Дата
Msg-id
CAJrrPGeQdr-YfLdeGxMFb4erqNWU77E49mD2HoHPntHTBY26Ag@mail.gmail.com
Ответ на
Re: Removal of duplicate variable declarations in fe-connect.c (Michael Paquier)
Список
Дерево обсуждения
Removal of duplicate variable declarations in fe-connect.c Haribabu Kommi <kommi.haribabu@gmail.com>
Re: Removal of duplicate variable declarations in fe-connect.c Michael Paquier <michael@paquier.xyz>
Re: Removal of duplicate variable declarations in fe-connect.c Haribabu Kommi <kommi.haribabu@gmail.com>
On Fri, Feb 22, 2019 at 3:22 PM Michael Paquier <michael@paquier.xyz> wrote:
On Fri, Feb 22, 2019 at 11:33:17AM +1100, Haribabu Kommi wrote:
> During the development of another feature, I found that same local
> variables are declared twice.
> IMO, there is no need of again declaring the local variables. Patch
> attached.

Indeed, fixed.  That's not a good practice, and each variable is
assigned in its own block before getting used, so there is no
overlap.

Thanks.

Regards,
Haribabu Kommi
Fujitsu Australia
В списке pgsql-hackers по дате отправления
Предыдущее
От: Haribabu Kommi
Дата:
Следующее
От: Haribabu Kommi
Дата:
FAQ