FindDefinedSymbol() is subtly broken
От
John Naylor
Тема
FindDefinedSymbol() is subtly broken
Дата
Msg-id
CAJVSVGXM_n32hTTkircW4_K1LQFsJNb6xjs0pAP4QC0ZpyJfPQ@mail.gmail.com
Список
Дерево обсуждения
FindDefinedSymbol() is subtly broken John Naylor <jcnaylor@gmail.com>
Re: FindDefinedSymbol() is subtly broken Tom Lane <tgl@sss.pgh.pa.us>
Long story short: It expects an array of paths, but will die if it can't find the symbol in the first path. Arguably it's a bug, but since the original use case for multiple paths is long gone anyway, it might never occur in practice. The attached patch changes it to expect a single path. Also attached: a few minor build script cleanups I've noticed along the way: -more accurate error message -s/print sprintf/printf/ -a recent perltidy change made a couple multi-line strings look odd, so use heredocs (which other scripts use in this case anyway) -make generated file footers match project style -remove a duplicate comment -John Naylor
В списке pgsql-hackers по дате отправления