On Thu, Jan 26, 2012 at 10:59 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Thu, Jan 26, 2012 at 11:41 AM, Merlin Moncure <mmoncure@gmail.com> wrote:
>> On Thu, Jan 26, 2012 at 8:18 AM, Abhijit Menon-Sen <ams@toroid.org> wrote:
>>> This is just to confirm that the patch applies and builds and works
>>> fine (though of course it does take a long time… pity there doesn't
>>> seem to be any easy way to add progress indication like -i has).
>>
>> On any non server grade hardware you'd probably want to disable
>> synchronous_commit while loading. FWIW, this is a great addition to
>> pgbench.
>
> Do you object to separating out the three different things the patch
> does and adding separate options for each one? If so, why? I find
> them independently useful.
I didn't take a position on that -- although superficially it seems
like more granular control is good (and you can always group options
together with a 'super option' like as in cp -a) -- just making a
general comment on the usefulness of testing against records that
don't have the same xid.
merlin