On Thu, Aug 28, 2014 at 12:55 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Wed, Aug 27, 2014 at 10:59 PM, Alvaro Herrera <alvherre@2ndquadrant.com>
> wrote:
>>
>> Not necessarily, because it's harmless. It's there for purely
>> aesthetical reasons, so it's your choice whether to add it or not.
>> Having it there is slightly easier on somebody reading the code,
>> perhaps.
Agreed.
> On my side, that's up to you Fujii-san. The patch does what it states, I
> only think that this extra 0 should be added either everywhere or nowhere.
Yep. I added extra 0 everywhere.
Ok, I just applied the patch. Thanks for the review!
> Not mandatory either: drop test_param_unit in the regression tests after
> running the test queries.
I don't have strong opinion about this. There are many tables which
regression test creates but doesn't drop. But if you strongly think that
the table must be dropped, I'm OK with that.
Regards,
--
Fujii Masao