pg_rewind and log messages

Hi,

I found that pg_rewind has several problems about its log messages.

(1)
It outputs an error message to stdout not stderr.

(2)
The tool name should be added at the head of log message as follows,
but not in pg_rewind.
   pg_basebackup: no target directory specified

(3)
>    if (datadir_source == NULL && connstr_source == NULL)
>    {
>        pg_fatal("no source specified (--source-pgdata or --source-server)\n");
>        pg_fatal("Try \"%s --help\" for more information.\n", progname);
>        exit(1);

Since the first call of pg_fatal exits with 1, the subsequent pg_fatal and exit
will never be called.

(4)
ISTM that set_pglocale_pgservice() needs to be called, but not in pg_rewind.

(5)
printf() is used to output an error in some files, e.g., timeline.c and
parsexlog.c. These printf() should be replaced with pg_log or pg_fatal?

Regards,

-- 
Fujii Masao