Re: Identify missing publications from publisher while create/alter subscription.

Поиск
Список
Период
Сортировка
От Dilip Kumar
Тема Re: Identify missing publications from publisher while create/alter subscription.
Дата
Msg-id CAFiTN-sbNq-1pC4Ji8fjLgF0cR-5b4Jk1BL3UdGZSfccu9ShSg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Identify missing publications from publisher while create/alter subscription.  (vignesh C <vignesh21@gmail.com>)
Ответы Re: Identify missing publications from publisher while create/alter subscription.
Список pgsql-hackers
Дерево обсуждения 
On Thu, May 6, 2021 at 7:22 PM vignesh C <vignesh21@gmail.com> wrote:
>

Some comments:
1.
I don't see any change in pg_dump.c, don't we need to dump this option?

2.
+ /* Try to connect to the publisher. */
+ wrconn = walrcv_connect(sub->conninfo, true, sub->name, &err);
+ if (!wrconn)
+ ereport(ERROR,
+ (errmsg("could not connect to the publisher: %s", err)));

Instead of using global wrconn, I think you should use a local variable?

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Japin Li
Дата:
Сообщение: Re: Identify missing publications from publisher while create/alter subscription.
Следующее
От: "tsunakawa.takay@fujitsu.com"
Дата:
Сообщение: RE: [bug?] Missed parallel safety checks, and wrong parallel safety