Re: [GSoC] Query History Integration with updatable query resultsetsand improvements

Поиск
Список
Период
Сортировка
От Yosry Muhammad
Тема Re: [GSoC] Query History Integration with updatable query resultsetsand improvements
Дата
Msg-id CAFSMqn_c84hufy8OJASCLM5B6REPivwSmBX+37rCp4U=cu2NyQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [GSoC] Query History Integration with updatable query resultsetsand improvements  (Yosry Muhammad <yosrym93@gmail.com>)
Список pgadmin-hackers
Дерево обсуждения


Hi,

On Tue, Aug 6, 2019, 6:46 PM Yosry Muhammad <yosrym93@gmail.com> wrote:
Hi,

On Tue, Aug 6, 2019, 6:01 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

Seems to work well :-). A few comments:

- Should we have an icon by the non-generated queries (the lightning flash) and the COMMITs etc (the commit/rollback icon as appropriate) as well? I think just having the icon for generated queries looks a little odd.

I am sorry I don't quite understand. Do you mean having an icon to show/hide user queries as well? I believe a checkbox is more appropriate anyway, maybe placed right above the history entries. I am going to need a design of the checkbox or styling guidlines though.

Another idea that came to my mind is to use a dropdown menu checkbox just next to the save data icon. Similar to auto-commot and auto-rollback checkboxs in the dropdown menu next to the execute (flash) icon. What do you think is better? This, or a checkbox right above the history entries?

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Yosry Muhammad
Дата:
Сообщение: Re: [GSoC] Query History Integration with updatable query resultsetsand improvements
Следующее
От: Aditya Toshniwal
Дата:
Сообщение: Re: [pgAdmin][RM4554] RE-SQL for trigger functions