Re: build remaining Flex files standalone

Поиск
Список
Период
Сортировка
От John Naylor
Тема Re: build remaining Flex files standalone
Дата
Msg-id CAFBsxsGq=jLMofR3BN1S1xJcaJsYcQnkWFRtRDObYVtDST0+Vg@mail.gmail.com
обсуждение исходный текст
Ответ на build remaining Flex files standalone  (John Naylor <john.naylor@enterprisedb.com>)
Ответы Re: build remaining Flex files standalone  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
Here are the rest. Most of it was pretty straightforward, with the
main exception of jsonpath_scan.c, which is not quite finished. That
one passes tests but still has one compiler warning. I'm unsure how
much of what is there already is really necessary or was cargo-culted
from elsewhere without explanation. For starters, I'm not sure why the
grammar has a forward declaration of "union YYSTYPE". It's noteworthy
that it used to compile standalone, but with a bit more stuff, and
that was reverted in 550b9d26f80fa30. I can hack on it some more later
but I ran out of steam today.

Other questions thus far:

- "BISONFLAGS += -d" is now in every make file with a .y file -- can
we just force that everywhere?

- Include order seems to matter for the grammar's .h file. I didn't
test if that was the case every time, and after a few miscompiles just
always made it the last inclusion, but I'm wondering if we should keep
those inclusions outside %top{} and put it at the start of the next
%{} ?

- contrib/cubeparse.y now has a global variable -- not terrific, but I
wanted to get something working first.

- I'm actually okay with guc-file.c now, but I'll still welcome
comments on that.

-- 
John Naylor
EDB: http://www.enterprisedb.com

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Следующее
От: Bharath Rupireddy
Дата:
Сообщение: Re: Patch proposal: New hooks in the connection path