On 29 July 2015 at 20:36, Joe Conway <joe.conway@crunchydata.com> wrote:
> On 07/29/2015 02:41 AM, Dean Rasheed wrote:
>> I don't think there is any point in adding the new function
>> transformPolicyClause(), which is identical to transformWhereClause().
>> You can just use transformWhereClause() with EXPR_KIND_POLICY. It's
>> already used for lots of other expression kinds.
>
>
> Ok -- I went back to using transformWhereClause. I'd still prefer to
> change the name -- more than half the uses of the function are for other
> than EXPR_KIND_WHERE -- but I don't feel that strongly about it.
>
>
>> There are a couple of places in test_rls_hooks.c that also need updating.
>
> done
>
>> I think that check_agglevels_and_constraints() and
>> transformWindowFuncCall() could be made to emit more targeted error
>> messages for EXPR_KIND_POLICY, for example "aggregate functions are
>> not allowed in policy USING and WITH CHECK expressions".
>
> done
>
> Unless there are other comments/objections, will commit this later today.
>
In the final error s/aggregate/window/. Other than that it looks good to me.
Regards,
Dean