Re: [pgAdmin4][RM#2989] To fix the issue in Table node

Поиск
Список
Период
Сортировка
От Joao De Almeida Pereira
Тема Re: [pgAdmin4][RM#2989] To fix the issue in Table node
Дата
Msg-id CAE+jjamZ94=4w+dR7bCYcPv0iQMj5bNmtpZdDCppVf2G_KNReA@mail.gmail.com
обсуждение исходный текст
Ответ на [pgAdmin4][RM#2989] To fix the issue in Table node  (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>)
Ответы Re: [pgAdmin4][RM#2989] To fix the issue in Table node  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Hi Murtuza,

The code change works, and I passed the patches through our pipeline and everything is green.
Personally I would love this bug fixes to have refactored the function into smaller chunk and made it more readable so that the next time someone need to check out a problem in the same area it is easier. I understand that without a good test coverage it is hard to have confidence while refactoring, but we need to start somewhere.

@Hackers
Here is a video that I saw some time ago about refactoring existing code and code complexity that is very interesting
In this video Sandi Metz does the Gilded Rose Kata in a talk in RailsConf 2014, and with it tries to demonstrate that code can be refactored and with that it make the code much more simpler. But the journey is not always simple and the complexity will increase before it get simpler. It is a good example of something that we can try with our code.


Thanks
Joao

On Tue, Mar 6, 2018 at 4:23 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue in Table node where wrong sql was generated while altering column.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Joao De Almeida Pereira
Дата:
Сообщение: Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayedwhen user try to insert data on table where primray key is in captial lettersand table contains OIDS
Следующее
От: Joao De Almeida Pereira
Дата:
Сообщение: Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image