Re: pgsql: Add TIDStore, to store sets of TIDs (ItemPointerData) efficientl

On Tue, Mar 26, 2024 at 12:22 PM John Naylor <johncnaylorls@gmail.com> wrote:
>
> On Tue, Mar 26, 2024 at 9:36 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > On Tue, Mar 26, 2024 at 7:16 AM David Rowley <dgrowleyml@gmail.com> wrote:
> > >
> > > Either "max_bytes" is a bad name for this variable or the * 1024L
> > > should be removed.
> > >
> >
> > Right. We discussed it on the original thread too[1]. Since we're
> > going to change the create API of TidStore, I'm going to fix it along
> > with the API changes[2]. Even if we don't make the API change, I'll
> > fix it individually.
>
> v79 still has the offending multiplier, btw. Those two things are
> unrelated anyway, so I don't see a reason to hold off making this
> small fix.

Okay, I'll fix them shortly.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com