On Mon, Jan 18, 2016 at 4:50 PM, Andres Freund <andres@anarazel.de> wrote:
> Now I'm equally unconvinced that it's worthwhile to do anything
> here. I just don't think benchmarking plays a role either way.
Well, that would be the crucial point on which we differ -- the
rest is all agreement. I don't think we should accept the patch
*in the absence* of benchmarking to show a result that is neutral
or better. Spinlocks are just too performance-critical and too
fussy to accept a change on the basis that "the source code looks
fine". IMO, anyway.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company