[pgadmin-hackers] [pgAdmin4][runtime][patch]: Fix compilation error for QtWebEngine

Поиск
Список
Период
Сортировка
От Neel Patel
Тема [pgadmin-hackers] [pgAdmin4][runtime][patch]: Fix compilation error for QtWebEngine
Дата
Msg-id CACCA4P361W5ae6GQWjK1Ec4y38TmcmWqGDK+6YbFrS1Uff6QdQ@mail.gmail.com
обсуждение исходный текст
Ответы Re: [pgadmin-hackers] [pgAdmin4][runtime][patch]: Fix compilationerror for QtWebEngine  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Hi Dave,

While building runtime with QtWebEngine, we found 2 compilation errors which was introduced due to previous commit in runtime.
  • We set "setNetworkAccessManager" in WebEnginePage which was only required for Webkit so removed that statement.
  • "triggerAction" on WebPage is only required for Qt > 5 with WebKit only. Not required for WebEngine so added that condition.
Please find attached fix for the same. Do review it and let me know for any queries.

Thanks,
Neel Patel
Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4][PATCH] To fix the issue with Node rename
Следующее
От: Surinder Kumar
Дата:
Сообщение: [pgadmin-hackers] Re: [pgAdmin4][Patch][RM2399]: Disabled row's background colordisappeared on save in View data