Re: [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree

Поиск
Список
Период
Сортировка
От Juan José Santamaría Flecha
Тема Re: [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree
Дата
Msg-id CAC+AXB0Mif-bfRz9TTX1W5tSjGcOHKAoPrMTk3aLfeZe6NYThA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree  (Andrew Dunstan <andrew@dunslane.net>)
Ответы Re: [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree
Список pgsql-hackers
Дерево обсуждения

On Tue, Jan 18, 2022 at 5:49 PM Andrew Dunstan <andrew@dunslane.net> wrote:

On 1/18/22 04:41, Juan José Santamaría Flecha wrote:
> In [1] capacity for $SUBJECT was added to most of the batch scripts,
> but clean.bat was not included. I propose to do so with the attached
> patch.


That looks a bit ugly. How about this (untested) instead?

It is WFM, so I am fine with it. 

> By the way, are pgbison.bat and pgflex.bat directly called anywhere?

Not to my knowledge. One of the things that's annoying about them is
that the processor names are hardcoded, so if you install winflexbison
as I usually do you have to rename the executables (or rename the
chocolatey shims) or the scripts won't work.

We could use those batches to get to the hardcoded name, but that would probably be as annoying as renaming. If those batches serve no purpose right now, it should be fine to remove them from the tree. I use the executables from a MinGW installation, and they keep their actual name.

Regards,

Juan José Santamaría Flecha

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Push down time-related SQLValue functions to foreign server
Следующее
От: "sergei sh."
Дата:
Сообщение: Re: [PATCH] reduce page overlap of GiST indexes built using sorted method