Re: pgsql: Fix union for pgstat message types

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: pgsql: Fix union for pgstat message types
Дата
Msg-id CABUevEwG_xigTB+7=EzM5o8EexxQ5_H-e5V9JFzD+aQ76NTsdA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: pgsql: Fix union for pgstat message types  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: pgsql: Fix union for pgstat message types
Список pgsql-committers
On Sat, May 4, 2019 at 5:54 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> On Wed, May 01, 2019 at 10:34:52AM +0000, Magnus Hagander wrote:
>> Fix union for pgstat message types

> Should the tempfile bit be backported? That message was added in 9.2.

It's just cosmetic I think.  The main point of having everything in
the union is to make sure the union's size/alignment are sufficient,
but the tempfile message isn't anywhere near creating an issue there.

That was my thought as well. It's really only needed when we add new things, to make sure we don't make those mistakes again. And nobody should be adding new pgstat messages in old branches. 

--

В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: pgsql: Fix union for pgstat message types
Следующее
От: Peter Eisentraut
Дата:
Сообщение: pgsql: pg_verify_checksums: Fix message punctuation