Re: Patch review for logging hooks (CF 2012-01)

Поиск
Список
Период
Сортировка
От Marti Raudsepp
Тема Re: Patch review for logging hooks (CF 2012-01)
Дата
Msg-id CABRT9RAUMWifGz7CCDokZSMd+8RwbLjguyOekGWTOrG-We6Tgg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Patch review for logging hooks (CF 2012-01)  (Martin Pihlak <martin.pihlak@gmail.com>)
Ответы Re: Patch review for logging hooks (CF 2012-01)  (Martin Pihlak <martin.pihlak@gmail.com>)
Список pgsql-hackers
Hi!

On Tue, Jan 17, 2012 at 23:07, Martin Pihlak <martin.pihlak@gmail.com> wrote:
>> I think the hook warrants a comment that, whether the messages will be
>> seen, depends on the log_min_messages setting.
>
> Comment added.

Nice :)

It seems you missed a comment, that the current implementation is also
affected by client_min_messages. I think that being affected by
client-specific settings is surprising. I would put the
if(emit_log_hook) inside the existing if(edata->output_to_server)
condition. Unless you have some reason to do it this way?

Regards,
Marti


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Martin Pihlak
Дата:
Сообщение: Re: Patch review for logging hooks (CF 2012-01)
Следующее
От: Daniel Farina
Дата:
Сообщение: Re: Should we add crc32 in libpgport?