Re: [WIP] pg_ping utility

Поиск
Список
Период
Сортировка
Искать
От
Michael Paquier
Тема
Re: [WIP] pg_ping utility
Дата
Msg-id
CAB7nPqTTPpSxtgUBPR1_HCdWKam1FNTSLE1UhVJRmeqEwP6ZgQ@mail.gmail.com
Ответ на
Список
Дерево обсуждения
[WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Thom Brown <thom@linux.com>
Re: [WIP] pg_ping utility Andres Freund <andres@2ndquadrant.com>
Re: [WIP] pg_ping utility Tom Lane <tgl@sss.pgh.pa.us>
Re: [WIP] pg_ping utility "David Johnston" <polobo@yahoo.com>
Re: [WIP] pg_ping utility Tom Lane <tgl@sss.pgh.pa.us>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Tom Lane <tgl@sss.pgh.pa.us>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Tom Lane <tgl@sss.pgh.pa.us>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [WIP] pg_ping utility Thom Brown <thom@linux.com>
Re: [WIP] pg_ping utility Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Peter Eisentraut <peter_e@gmx.net>
Re: [WIP] pg_ping utility Bruce Momjian <bruce@momjian.us>
Re: [WIP] pg_ping utility Peter Eisentraut <peter_e@gmx.net>
Re: [WIP] pg_ping utility Dimitri Fontaine <dimitri@2ndQuadrant.fr>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Bruce Momjian <bruce@momjian.us>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility "Erik Rijkers" <er@xs4all.nl>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Robert Haas <robertmhaas@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Robert Haas <robertmhaas@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Robert Haas <robertmhaas@gmail.com>
Re: [WIP] pg_ping utility Craig Ringer <craig@2ndQuadrant.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Tom Lane <tgl@sss.pgh.pa.us>
Re: [WIP] pg_ping utility Michael Paquier <michael.paquier@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Peter Eisentraut <peter_e@gmx.net>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Christopher Browne <cbbrowne@gmail.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>
Re: [WIP] pg_ping utility Phil Sorber <phil@omniti.com>


On Sat, Dec 22, 2012 at 4:07 AM, Phil Sorber <phil@omniti.com> wrote:

Added new version with default verbose and quiet option. Also updated
docs to reflect changes.
Thanks for the updated patches.

Here is the status about the binary patch:
- Code compiles without any warnings
- After testing the patch, it behaves as expected, default option is now verbose, the output can be hidden using -q or --quiet
However, I still have the following comments:
- in pg_isready.c, the function "help" needs to be static.
- the list of options called with getopt_long should be classified in alphabetical order (the option q is not at the correct position)
d:h:p:U:qV => d:h:p:qU:V

Then, about the doc patch:
- docs compile correctly (I did a manual check)
- I am not a native English speaker, but the docs look correct to me. There are enough examples and description is enough. No problems either with the sgml format.

Once the 2 small things I noticed are fixed, this patch can be marked as ready for committer.
Thanks,
--
Michael Paquier
http://michael.otacoo.com
В списке pgsql-hackers по дате отправления
От: Simon Riggs
Дата:
От: Phil Sorber
Дата:
Сообщение: Re: [WIP] pg_ping utility
FAQ