Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug)

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug)
Дата
Msg-id CAB7nPqRcV6RrN_VuV2zRV0qhkamxHTUAJFJmfnJnFTL+w6eBpg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug)  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug)  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Fri, Mar 25, 2016 at 9:17 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Thu, Mar 24, 2016 at 9:50 AM, Aleksander Alekseev
> <a.alekseev@postgrespro.ru> wrote:
>> Currently this procedure has two arguments --- init_size and max_size.
>> But since shared hash tables have fixed size there is little sense to
>> pass two arguments. In fact currently ShmemInitHash is always called
>> with init_size == max_size with only one exception, InitLocks procedure
>> (see lock.c), which I believe is actually a bug.
>
> No, I think we left it that way on purpose.  I don't remember the
> discussion exactly, but I don't think it's hurting anything.

My instinct is telling me that this is useful in this shape for
plugins, and that it has been designed on purpose for that.
-- 
Michael



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Aleksander Alekseev
Дата:
Сообщение: Re: Small patch: Change calling convention for ShmemInitHash (and fix possible bug)
Следующее
От: Andrew Dunstan
Дата:
Сообщение: Re: VS 2015 support in src/tools/msvc