Re: Making tab-complete.c easier to maintain

On Thu, Nov 26, 2015 at 2:45 PM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> What do you think about this solution?

<please do not top-post, it breaks the logic of the thread>

This patch fails to compile on OSX:
Undefined symbols for architecture x86_64: "_ExceptionalCondition", referenced from:     _pg_regexec in regexec.o
_cfindin regexec.o     _find in regexec.o     _newdfa in regexec.o     _cfindloop in regexec.o     _shortest in
regexec.o    _cdissect in regexec.o     ...
 
So, to begin with, this may be better if replugged as a standalone
library, aka moving the regexp code into src/common for example or
similar. Also, per the comments on top of rcancelrequested,
rstacktoodeep and rcancelrequested, returning unconditionally 0 is not
a good idea for -DFRONTEND. Callbacks should be defined and made
available for callers.

-       {"EVENT TRIGGER", NULL, NULL},
+       {"EVENT TRIGGER", Query_for_list_of_event_triggers, NULL},       {"EXTENSION", Query_for_list_of_extensions},
-       {"FOREIGN DATA WRAPPER", NULL, NULL},
+       {"FOREIGN DATA WRAPPER", Query_for_list_of_fdws, NULL},       {"FOREIGN TABLE", NULL, NULL},       {"FUNCTION",
NULL,&Query_for_list_of_functions},       {"GROUP", Query_for_list_of_roles},       {"LANGUAGE",
Query_for_list_of_languages},      {"INDEX", NULL, &Query_for_list_of_indexes},
 
-       {"MATERIALIZED VIEW", NULL, NULL},
+       {"MATERIALIZED VIEW", NULL, &Query_for_list_of_matviews},
This has value as a separate patch.

The patch has many whitespaces, and unrelated diffs.
-- 
Michael