Re: Window Function "Run Conditions"

Поиск
Список
Период
Сортировка
От David Rowley
Тема Re: Window Function "Run Conditions"
Дата
Msg-id CAApHDvrqaRrmS6Ee7hQ5NfRpfNGGS+Y0dhootWvkyUxMeoTm7w@mail.gmail.com
обсуждение исходный текст
Ответ на Window Function "Run Conditions"  (David Rowley <dgrowleyml@gmail.com>)
Ответы Re: Window Function "Run Conditions"  (David Rowley <dgrowleyml@gmail.com>)
Список pgsql-hackers
On Thu, 7 Apr 2022 at 15:41, Zhihong Yu <zyu@yugabyte.com> wrote:
> +                * We must keep the original qual in place if there is a
> +                * PARTITION BY clause as the top-level WindowAgg remains in
> +                * pass-through mode and does nothing to filter out unwanted
> +                * tuples.
> +                */
> +               *keep_original = false;
>
> The comment talks about keeping original qual but the assignment uses the value false.
> Maybe the comment can be rephrased so that it matches the assignment.

Thanks. I've just removed that comment locally now. You're right, it
was out of date.

David



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN
Следующее
От: Julien Rouhaud
Дата:
Сообщение: Re: Showing I/O timings spent reading/writing temp buffers in EXPLAIN