Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options

Поиск
Список
Период
Сортировка
От David Rowley
Тема Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options
Дата
Msg-id CAApHDvqkYaPnfRkE+gdme0wVZiyFsJQYgZx=T15+5_qySjwfnw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options  (Zhihong Yu <zyu@yugabyte.com>)
Ответы Re: Allow WindowFuncs prosupport function to use more optimal WindowClause options
Список pgsql-hackers
Thanks for having a look at this.

On Fri, 14 Oct 2022 at 10:52, Zhihong Yu <zyu@yugabyte.com> wrote:
> +       req->frameOptions = (FRAMEOPTION_ROWS |
> +                            FRAMEOPTION_START_UNBOUNDED_PRECEDING |
> +                            FRAMEOPTION_END_CURRENT_ROW);
>
> The bit combination appears multiple times in the patch.
> Maybe define the combination as a constant in supportnodes.h and reference it in the code.

I don't believe supportnodes.h has any business having any code that's
related to actual implementations of the support request type.  If we
were to have such a definition then I think it would belong in
windowfuncs.c.  I'd rather see each implementation of the support
request spell out exactly what they mean, which is what the patch does
already.

David



В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: Re: Warning about using pg_stat_reset() and pg_stat_reset_shared()
Следующее
От: Richard Guo
Дата:
Сообщение: Re: havingQual vs hasHavingQual buglets