Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)

Поиск
Список
Период
Сортировка
От Dong Wook Lee
Тема Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)
Дата
Msg-id CAAcByaJK_ivH2555T2kwDa4h67eh+U8eXTRctp_OjodmFyctXw@mail.gmail.com
обсуждение исходный текст
Ответ на [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Ответы Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)  (Dong Wook Lee <sh95119@gmail.com>)
Список pgsql-hackers
Дерево обсуждения 
Hi,

I've applied your patch. I think it's reasonable.
but  IMHO It looks more complicated to read because of many conditions
in if statement.
so what about just moving up if-statement?

Thanks.
Dong Wook Lee

2022년 2월 9일 (수) 오후 7:56, Ranier Vilela <ranier.vf@gmail.com>님이 작성:
>
> Hi,
>
> I think this change can improve this particular function by avoiding touching value if not needed.
> Test if not isnull is cheaper than test TupleDescAttr is -1.
>
> best regards,
>
> Ranier Vilela
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Julien Rouhaud
Дата:
Сообщение: Re: Add tag/category to the commitfest app
Следующее
От: Dagfinn Ilmari Mannsåker
Дата:
Сообщение: Re: Replacing TAP test planning with done_testing()