Re: patch: Add missing descriptions for rmgr APIs

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: patch: Add missing descriptions for rmgr APIs
Дата
Msg-id CAA4eK1KxjhVG35MmBPg3ggkMr1nz21ewr5c_DbVcMmOCzBSKMg@mail.gmail.com
обсуждение исходный текст
Ответ на patch: Add missing descriptions for rmgr APIs  ("kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>)
Ответы RE: patch: Add missing descriptions for rmgr APIs  ("kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>)
Список pgsql-hackers
On Mon, Aug 29, 2022 at 8:48 AM kuroda.hayato@fujitsu.com
<kuroda.hayato@fujitsu.com> wrote:
>
> Hi hackers,
>
> While reading codes related with logical decoding,
> I thought that following comment in rmgrlist.h is not consistent.
>
> > /* symbol name, textual name, redo, desc, identify, startup, cleanup */
>
> This comment describes a set of APIs that the resource manager should have, but functions for {mask, decode} are
missedhere.
 
>

Your observation seems correct to me but you have not updated the
comment for the mask. Is there a reason for the same?

-- 
With Regards,
Amit Kapila.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Kapila
Дата:
Сообщение: Re: Handle infinite recursion in logical replication setup
Следующее
От: Anton Voloshin
Дата:
Сообщение: Re: Make #else/#endif comments more consistent