Re: [PATCH] Refactoring of LWLock tranches

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: [PATCH] Refactoring of LWLock tranches
Дата
Msg-id CAA4eK1K-__vWwtTSAg9tEr-63Sv8Jr6ncKqA_jYk7G750nD0Fw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Refactoring of LWLock tranches  (Jesper Pedersen <jesper.pedersen@redhat.com>)
Список pgsql-hackers
On Tue, Jan 5, 2016 at 7:24 PM, Jesper Pedersen <jesper.pedersen@redhat.com> wrote:
>
> On 01/05/2016 08:04 AM, Amit Kapila wrote:
>>
>> I am not aware of such cases, however the reason I have kept it was for
>> backward-compatability, but now I have removed it in the attached patch.
>>
>> Apart from that, I have updated the docs to reflect the changes related
>> to new API's.
>>
>
> xfunc.sgml:
>
> +                after allocating LWLocks, verify that the number of allocated
> +                LWLocks is same as requested;
>
> Did you mean to put this check in ?
>
Yes, it is good to check, right now I have added Assert in code as
I think it is a dev problem to over-allocate the lwlocks.


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jim Nasby
Дата:
Сообщение: Re: Add schema-qualified relnames in constraint error messages.
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Add schema-qualified relnames in constraint error messages.