On Sat, May 25, 2019 at 8:36 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Amit Kapila <amit.kapila16@gmail.com> writes:
> > I have taken one pass over it and all fixes seem to be correct and got
> > introduced in v12. I will re-verify them once again and then commit
> > your patch if I don't found any problem. In the meantime, if anyone
> > else wants to look at it, that would be great.
>
> FWIW, I'd counsel against applying the changes in imath.h/.c, as that
> is not our code, and unnecessary variations from upstream will just
> make it harder to track upstream.
>
This occurred to me as well while reviewing, but I thought typo fixes
should be fine. Anyway, I have excluded those before pushing. So, if
we want to fix these, then maybe one has to first get this fixed in
upstream first and then take from there.
> The rest of this looks fine.
>
Thanks, pushed.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com