Re: DROP TABLE can crash the replication sync worker

Поиск
Список
Период
Сортировка
От Amit Kapila
Тема Re: DROP TABLE can crash the replication sync worker
Дата
Msg-id CAA4eK1JQ9yoC8TuaTsexWreONW-UiQBhFbtsi6DJJcphpBO2Zw@mail.gmail.com
обсуждение исходный текст
Ответ на DROP TABLE can crash the replication sync worker  (Peter Smith <smithpb2250@gmail.com>)
Ответы Re: DROP TABLE can crash the replication sync worker
Список pgsql-hackers
On Wed, Feb 3, 2021 at 2:53 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Hackers.
>
> As discovered in another thread [master] there is an *existing* bug in
> the PG HEAD code which can happen if a DROP TABLE is done at same time
> a replication tablesync worker is running.
>
> It seems the table's relid that the sync worker is using gets ripped
> out from underneath it and is invalidated by the DROP TABLE. Any
> subsequent use of that relid will go wrong.
>

Where exactly did you pause the tablesync worker while dropping the
table? We acquire the lock on the table in LogicalRepSyncTableStart
and then keep it for the entire duration of tablesync worker so drop
table shouldn't be allowed.

-- 
With Regards,
Amit Kapila.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ibrar Ahmed
Дата:
Сообщение: Re: Next Commitfest Manager.
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: Typo in tablesync comment