Re: Small documentation improvement for ALTER SUBSCRIPTION

Поиск
Список
Период
Сортировка
Искать
От
Amit Kapila
Тема
Re: Small documentation improvement for ALTER SUBSCRIPTION
Дата
Msg-id
CAA4eK1JHe5PRvxVUv33KdZxt2CcBgZzA09S9mGdqRFSoEcfWmw@mail.gmail.com
Ответ на
Список
Дерево обсуждения
Small documentation improvement for ALTER SUBSCRIPTION Masahiko Sawada <sawada.mshk@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Daniel Gustafsson <daniel@yesql.se>
Re: Small documentation improvement for ALTER SUBSCRIPTION Masahiko Sawada <sawada.mshk@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Amit Kapila <amit.kapila16@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Peter Smith <smithpb2250@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Amit Kapila <amit.kapila16@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Peter Smith <smithpb2250@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Masahiko Sawada <sawada.mshk@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Amit Kapila <amit.kapila16@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Masahiko Sawada <sawada.mshk@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Daniel Gustafsson <daniel@yesql.se>
Re: Small documentation improvement for ALTER SUBSCRIPTION Masahiko Sawada <sawada.mshk@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Daniel Gustafsson <daniel@yesql.se>
Re: Small documentation improvement for ALTER SUBSCRIPTION Masahiko Sawada <sawada.mshk@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Amit Kapila <amit.kapila16@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Daniel Gustafsson <daniel@yesql.se>
Re: Small documentation improvement for ALTER SUBSCRIPTION Daniel Gustafsson <daniel@yesql.se>
Re: Small documentation improvement for ALTER SUBSCRIPTION Masahiko Sawada <sawada.mshk@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Greg Nancarrow <gregn4422@gmail.com>
Re: Small documentation improvement for ALTER SUBSCRIPTION Peter Smith <smithpb2250@gmail.com>
On Sun, Aug 8, 2021 at 10:21 AM Peter Smith  wrote:
>
> On Sat, Aug 7, 2021 at 4:33 PM Amit Kapila  wrote:
> >
> > On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada  wrote:
> > >
> > > Hi all,
> > >
> > > When reading the doc of ALTER SUBSCRIPTION I realized that 'refresh
> > > options' in the following paragraph is not tagged:
> > >
> > > ---
> > > Additionally, refresh options as described under REFRESH PUBLICATION
> > > may be specified, except in the case of DROP PUBLICATION.
> > > ---
> > >
> > > When I read it for the first time, I got confused because we actually
> > > have the 'refresh' option and this description in the paragraph of the
> > > 'refresh' option. I think we can improve it by changing to
> > > 'refresh_option'. Thoughts?
> > >
> >
> > I see that one can get confused but how about changing it to
> > "Additionally, refresh options as described under REFRESH
> > PUBLICATION (refresh_option) may
> > be specified,.."? I think keeping "refresh options" in the text would
> > be good because there could be multiple such options.
> >
>
> I feel like it would be better to reword it in some way that avoids
> using parentheses because they look like part of the syntax instead of
> just part of the sentence.
>

Fair enough, feel free to propose if you find something better or if
you think the current text in the docs is good.

-- 
With Regards,
Amit Kapila.


В списке pgsql-hackers по дате отправления
От: David Rowley
Дата:
От: Amit Kapila
Дата:
FAQ