On Mon, Apr 4, 2022 at 8:41 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Mon, Apr 4, 2022 at 11:50 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > Another minor point is that I think it is better to use DatumGetLSN to
> > read this in GetSubscription as we use LSNGetDatum while storing it. I
> > am not sure if there is any direct problem due to this but that looks
> > consistent to me.
>
> But it seems not consistent with other usages since we don't normally
> use DatumGetXXX to get values directly from C struct.
>
Okay, I see that for sequences also we don't use it, so we can
probably leave it as it is.
--
With Regards,
Amit Kapila.